Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert resource to prevent breaking changes #30

Closed
wants to merge 7 commits into from
Closed

Revert resource to prevent breaking changes #30

wants to merge 7 commits into from

Conversation

vmanilo
Copy link
Owner

@vmanilo vmanilo commented Sep 14, 2023

Resolves breaking changes

Changes

  • reverted resource

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6181059476

  • 548 of 604 (90.73%) changed or added relevant lines in 5 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.1%) to 90.672%
Changes Missing Coverage Covered Lines Changed/Added Lines %
twingate/internal/provider/resource/helper.go 9 12 75.0%
twingate/internal/test/acctests/helper.go 10 14 71.43%
twingate/provider.go 72 80 90.0%
twingate/v2/provider.go 117 134 87.31%
twingate/internal/provider/resource/resource.go 340 364 93.41%
Files with Coverage Reduction New Missed Lines %
twingate/internal/provider/resource/resource.go 13 91.82%
Totals Coverage Status
Change from base Build 6129393285: 1.1%
Covered Lines: 5152
Relevant Lines: 5682
💛 - Coveralls

@vmanilo vmanilo closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmanilo @coveralls